[CORRUPTED] Synthetic Benchmark PR #49578 - fix(updater): Stop expiring secret prematurely#6
Open
tomerqodo wants to merge 3 commits intobase_pr_49578_20251124_9143from
Open
Conversation
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Louis Chmn <louis@chmn.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR nextcloud#49578
Type: Corrupted (contains bugs)
Original PR Title: fix(updater): Stop expiring secret prematurely
Original PR Description: <!--
-->
updater.secretcreation and expiration nextcloud/server#45714Summary
nextcloud#43967 introduced a regression in the handling of the expiration of
updater.secret. The result is thatupdater.secretis expired at the next job interval (~10 minutes). If the web Updater takes >10 minutes this prevents it from continuing.updater.secret.createdvalue when we expire a secretconfig_is_read_onlyin theAdminControllerResetTokenbackground job unit tests to catch the scenario addressed by this PRResetTokenbackground job unit test coverage in generalAdminControllerunit test coverage in generalTODO
staticused in theResetTokentest since it didn't seem to serve a purpose but I may have broken it so may require another look)Checklist
Original PR URL: nextcloud#49578
Issues Breakdown